Conversation
- Adds a new `-q` / `--quiet` flag to the CLI options to avoid adding the shelf `logRequests` middleware. - Fully documents the `Dhttpd.start` public API. - Updates `test/command_test.dart` to verify that no output is emitted when `--quiet` is set. - Rebuilds `options.g.dart` and `version.dart`. - Syncs the generated README output and bumps version to 4.3.0.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new --quiet flag (-q) to the dhttpd server, allowing users to disable request logging. The changes involve updating the command-line option parsing, modifying the Dhttpd.start method to conditionally apply the request logging middleware based on this flag, and adding a new test case to verify the functionality. Version numbers across CHANGELOG.md, lib/src/version.dart, and pubspec.yaml have been updated to 4.3.0, and the README.md has been updated to document the new flag.
1 participant
-q/--quietflag to the CLI options to avoid adding the shelflogRequestsmiddleware.Dhttpd.startpublic API.test/command_test.dartto verify that no output is emitted when--quietis set.options.g.dartandversion.dart.